dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Fix 21313 - Use curl's retry-all-errors option

Open Geod24 opened this issue 5 years ago • 5 comments

Curl would only retry 400s, 500s, and timeout, not connection closed by peer
or other kind of transition connections.
Using '--retry-all-errors' fixes this, however care must be put into avoiding
the usage of pipes (see manual).
Additionally, the total timeout was increased to 5 minutes as requested by Walter,
and the connection timeout was also extended to reflect to be more tolerant.

Geod24 avatar Oct 18 '20 15:10 Geod24

Thanks for your pull request, @Geod24!

Bugzilla references

Auto-close Bugzilla Severity Description
21313 normal TestSuite heisenbug in buildkite/dmd Build

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11884"

dlang-bot avatar Oct 18 '20 15:10 dlang-bot

Ergh, --retry-all-errors was introduced in cURL 7.71.0, which was released 2020-06, a tad too recent... Will switch to a manual retry then...

Geod24 avatar Oct 18 '20 15:10 Geod24

@Geod24 what is the status on this?

RazvanN7 avatar Jan 07 '21 15:01 RazvanN7

ping

RazvanN7 avatar Jan 12 '21 09:01 RazvanN7

Ping @Geod24

dkorpel avatar Mar 25 '22 20:03 dkorpel