dmd
dmd copied to clipboard
Fix 21313 - Use curl's retry-all-errors option
Curl would only retry 400s, 500s, and timeout, not connection closed by peer
or other kind of transition connections.
Using '--retry-all-errors' fixes this, however care must be put into avoiding
the usage of pipes (see manual).
Additionally, the total timeout was increased to 5 minutes as requested by Walter,
and the connection timeout was also extended to reflect to be more tolerant.
Thanks for your pull request, @Geod24!
Bugzilla references
| Auto-close | Bugzilla | Severity | Description |
|---|---|---|---|
| ✓ | 21313 | normal | TestSuite heisenbug in buildkite/dmd Build |
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub run digger -- build "master + dmd#11884"
Ergh, --retry-all-errors was introduced in cURL 7.71.0, which was released 2020-06, a tad too recent... Will switch to a manual retry then...
@Geod24 what is the status on this?
ping
Ping @Geod24