dlang.org icon indicating copy to clipboard operation
dlang.org copied to clipboard

Update to special member functions ddoc in c++ interop

Open Emmankoko opened this issue 1 year ago • 1 comments

This PR is an update to the special function header in C++ inter documentation. one direct change was to replace special function header to operator overloading since we have already talked about constructors and destructors.

this is a preview of how it is looking like now please let me know any suggested changes, thanks! https://dtest.dlang.io/artifact/website-5388b9dcb36ee1089914e5d68ff0da5d7a87f9a0-ec4cd8bc11f96e39d04ef037f2f1f3e5/web/spec/cpp_interface.html#operator-overloading

@dkorpel @Geod24

Emmankoko avatar Apr 30 '24 23:04 Emmankoko

Thanks for your pull request and interest in making D better, @Emmankoko! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

dlang-bot avatar Apr 30 '24 23:04 dlang-bot

Looks good! I just applied some style changes.

dkorpel avatar May 09 '24 19:05 dkorpel