dlang
[spec/lex] Optional IdentifierStart after string/numeric literal suffix
This is for https://github.com/dlang/dmd/pull/15339.
I have ignored the ImaginarySuffix FloatLiteral variants, as they are deprecated.
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:andReturns:)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
Your PR doesn't reference any Bugzilla issue.
If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
In the other PR you said:
More importantly, we can never add any new literal suffixes without breaking code if we don't have an error.
When you only put IdentifierStartError after existing suffixes, you still can't add new suffixes without breaking code.
Yes, this change will only catch existing suffixes running into an identifier. The more general errors could be done afterwards - now there's a way to handle them in the grammar.