dlang.org icon indicating copy to clipboard operation
dlang.org copied to clipboard

[spec/expression] Tweak examples

Open ntrel opened this issue 1 year ago • 1 comments

Make more examples compilable/runnable. Use static assert instead of writeln(typeid for IsExpression examples. Show in more places that static if identifiers outlast static if. Use SPEC_RUNNABLE_EXAMPLE_COMPILE for typeif and SpecialKeyword examples that only call write and don't throw (speed up tests a bit).

ntrel avatar Aug 12 '22 13:08 ntrel

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

dlang-bot avatar Aug 12 '22 13:08 dlang-bot