dlang.org icon indicating copy to clipboard operation
dlang.org copied to clipboard

Use the FullCalendar widget instead of the embedded Google widget

Open wilzbach opened this issue 7 years ago • 8 comments

See also:

  • https://github.com/dlang/dlang.org/pull/2222#issuecomment-367156497
  • https://fullcalendar.io/

FullCalendar allows a lot of customization and also comes with a few themes:

https://fullcalendar.io/js/fullcalendar-3.8.2/demos/themes.html

wilzbach avatar Feb 22 '18 19:02 wilzbach

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

dlang-bot avatar Feb 22 '18 19:02 dlang-bot

CC @CyberShadow - are you okay with this too? The only downside here is that a Google calendar API key needs to be exposed, but I restricted the domain to localhost, dlang.org and dlang.io which should make abuse harder. And if this ever becomes a problem we can easily revert back to the old widget.

wilzbach avatar Mar 14 '18 11:03 wilzbach

For some reason some of the CDNs used on this page and dlang.org are timing out for me. Is it just me?

CyberShadow avatar Mar 14 '18 11:03 CyberShadow

When it does load, the calendar I see is completely blank. I see some events currently on https://dlang.org/calendar , but here there's nothing.

CyberShadow avatar Mar 14 '18 11:03 CyberShadow

Is it just me?

I think so. Does https://fullcalendar.io/js/fullcalendar-3.8.2/demos/themes.html work for you?

wilzbach avatar Mar 14 '18 11:03 wilzbach

Yep, that works fine.

CyberShadow avatar Mar 14 '18 12:03 CyberShadow

Interesting it works fine in my Chrome and Firefox:

image

What error do you get in your Firefox?

wilzbach avatar Mar 14 '18 13:03 wilzbach

No error, it's just blank.

CyberShadow avatar Mar 14 '18 13:03 CyberShadow