dlang.org icon indicating copy to clipboard operation
dlang.org copied to clipboard

Published 20 hours ago • verified publisher icon dlang

Run sub make evocations with -j$(nproc)

Open wilzbach opened this issue 6 years ago • 5 comments

Currently building dlang.org doesn't work well with -j due to not fully correct specified dependencies on the target definitions. However, there's no reson why we can't use parallelism for the individual sub makes.

wilzbach avatar Jan 15 '18 04:01 wilzbach

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

dlang-bot avatar Jan 15 '18 04:01 dlang-bot

~~IIRC this is the wrong way to do it, wasn't there something like MAKEFLAGS better suited for this?~~

CyberShadow avatar Jan 15 '18 08:01 CyberShadow

I'm uneasy about this. Why not fix the dependencies?

CyberShadow avatar Jan 15 '18 08:01 CyberShadow

Why not fix the dependencies?

Because I don't know where they are broken. Everything works fine on my machine - even with -j50, maybe we have already fixed this?

wilzbach avatar Jan 15 '18 16:01 wilzbach

Hmm, how about just adding -j$(NPROC) to the big guy - building DMD? It would still result in faster build time as DMD builds fine with -j.

wilzbach avatar Feb 08 '18 02:02 wilzbach