dlang-bot icon indicating copy to clipboard operation
dlang-bot copied to clipboard

auto-merge-squash drops all commit messages

Open MartinNowak opened this issue 7 years ago • 3 comments

Github's squash and merge button suggests all of the commit titles, but strips merge requests. Not sure about [squash] and !fixup commit messages, but would be sensible to strip those as well.

MartinNowak avatar Mar 24 '17 19:03 MartinNowak

Has been disabled for now by removing the auto-merge-squash labels. Should stay removed until dlang-bot learns to synthesized the correct commit message or can do rebase --autosquash itself.

MartinNowak avatar Jan 15 '18 16:01 MartinNowak

Should we just include a list of commits and their commit messages in the merge commit message, then?

CyberShadow avatar May 26 '21 23:05 CyberShadow

Usually we use squash when a contributor doesn't have a proper commit separation - e.g. create 30 commits as the result of review. So IMO we should pick the PR title / body instead.

Geod24 avatar May 27 '21 02:05 Geod24