core icon indicating copy to clipboard operation
core copied to clipboard

how to update fixed package versions from the `Add library +` button ?

Open 9il opened this issue 6 years ago • 3 comments

When a user adds the mir-algorithm library, mir-algorithm 3.4.4 will be added. Ideally is to replace them with *.

9il avatar Jul 06 '19 09:07 9il

The list of installed packages in the docker image is obtained dynamically here: https://github.com/dlang-tour/core/blob/9014e140e5006a6e58400924c8a4729a5cd43db7/source/exec/docker.d#L190 Everytime a new Docker image is built we fetch the newest available packages. Showing arbitrary versions however is not a good idea, since the user will expect them to work, while only a version per package is actually installed.

PetarKirov avatar Jul 07 '19 06:07 PetarKirov

Agreed. I mean "Add library" button at run.dlang.io. It has a fixed package version. Instead, it would be more sensitive to add "*". I couldn't find where 3.4.4 is hardcoded.

image

9il avatar Jul 07 '19 07:07 9il

Here:

https://github.com/dlang-tour/core/blob/9014e140e5006a6e58400924c8a4729a5cd43db7/public/static/js/tour-controller.js#L409

wilzbach avatar Jul 07 '19 17:07 wilzbach