libdparse icon indicating copy to clipboard operation
libdparse copied to clipboard

fix(parser): attributes are not always propagated/populated

Open ljmf00 opened this issue 3 years ago • 3 comments

Co-authored-by: Eyal Lotem [email protected] Signed-off-by: Luís Ferreira [email protected]


Adapted from https://github.com/weka/libdparse/commit/caac5e48884992aebddf1f3bd051f5c128d505d6 to upstream. CC @EyalIO .

Fixes #370 and somewhat related to #73.

ljmf00 avatar Sep 16 '22 13:09 ljmf00

Still requires testing.

ljmf00 avatar Sep 16 '22 13:09 ljmf00

Codecov Report

Merging #466 (b717b20) into master (19a8489) will increase coverage by 0.03%. The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   83.17%   83.20%   +0.03%     
==========================================
  Files          11       11              
  Lines        8338     8338              
==========================================
+ Hits         6935     6938       +3     
+ Misses       1403     1400       -3     
Impacted Files Coverage Δ
src/dparse/parser.d 91.39% <100.00%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19a8489...b717b20. Read the comment docs.

codecov[bot] avatar Sep 17 '22 16:09 codecov[bot]

we have the XPath based testing framework setup for this, I think that's the easiest way to test for an AST modification like this.

WebFreak001 avatar Sep 17 '22 16:09 WebFreak001