yardstick icon indicating copy to clipboard operation
yardstick copied to clipboard

Threshold is minimum rather than exact.

Open trans opened this issue 11 years ago • 2 comments

I am not sure why Yardstick would exit non-zero if coverage is above the set threshold, i.e. I don't know why any one would want it to be "exact" (for anything below 100%).

trans avatar Jan 15 '14 09:01 trans

@trans my rationale behind using an exact threshold is that if it changes, I usually want to know. If it improves, I want to raise the bar so that if my coverage drops I know about it right away. If it drops, then I know I'm letting things slide and I need to bring it back up.

I can understand that other people have different workflows. I wonder if perhaps having 3 flags:

  • minimum_threshold
  • maximum_threshold
  • threshold

Setting minimum_threshold would set the lower bounds, and maximum_threshold would set the upper bounds. Setting the threshold would set the first two flags, effectively making it so that the threshold needs to be an exact match, like it is now.

dkubb avatar Jan 16 '14 04:01 dkubb

I wonder, could it store the previous coverage score and thus be able to report changes between runs? Then it could simply return non-zero status if coverage goes down instead of up (or equal).

trans avatar Jan 19 '14 16:01 trans