Add composer.json

[SOF3]

For convenience of pulling from composer for phpstan

[dktapps]

Is there a reason not to just handle this the same way as any other virion?

[SOF3]

I'm not sure how any other virion is handled. Isn't phpstan + compose rthe standard way to setup this locally?

[dktapps]

I don't know. Virions are your domain.

[SOF3]

phpstan is not my domain though. Afaik it's not trivial to setup phpstan for projects that depend on other plugins or virions. Composer might be a good solution to this, but I don't know if that's what everyone is doing.

[dktapps]

It's easy enough, just add the src directory to scanDirectories.

[SOF3]

Yes, but you need to have cloned it locally first. This doesn't feel very standardized.

[dktapps]

I thought there was a procedure for installing virions locally?

[SOF3]

Not automatically. You would have to download them one by one on a CI environment. This is due to the unfortunate design choice that virions are declared in a Poggit-specific file.

[dktapps]

I thought that's what DEVirion was for ... It seems to me like your purpose would be better served by improving the virion installation process instead of littering every virion repository with composer.json files.

[SOF3]

I thought that's what DEVirion was for ... It seems to me like your purpose would be better served by improving the virion installation process instead of littering every virion repository with composer.json files.

Nope, devirion just loads virions from the virions folder.

[dktapps]

I don't think composer.lock should be committed here

[SOF3]

what's the general rule? no composer.lock for libraries?

[dktapps]

Yes, it's not used for libraries anyway. It's only useful for the top-level project where composer install is run, to lock dependencies to a known state.

[SOF3]

Obsoleted by #15