Dominik Kriegner

Results 82 comments of Dominik Kriegner

Maybe "transparent" is not a good word here. We use varies types of such converters in our lab to converge all the communication to Ethernet. The different types work all...

I try to catch up with the discussion: > Hmmm, I see. So, probably a [Moxa](https://www.moxa.com/en/products/industrial-edge-connectivity/serial-device-servers/general-device-servers) NPort or something like that? I do not know this particular one, but it...

One more note: IMHO this Serial/Ethernet translators can't be compared with the Prologix Adapter. The Prologix adapter has many commands it processes on its own via the same interface used...

Ok, I agree. Likely many Instruments need to adapt this new behavior but this can likely be done step by step. Regarding timeout: Indeed this is a valid concern, but...

I must say the more I think about it, the more I like the proposed solution. It defines a central place to define common Adapter arguments while still maintaining that...

> So, you have to check the contents of that dict, and strip out the baud_rate arg before passing it to your adapter ctor. You save the effort of looking...

Ok, if you want really everything in the `adapter_kwargs` I agree with @bilderbuchi that duplication is unavoidable and clearly a negative thing. I thought that `adapter_kwargs` will only contain what...

I understand (and agree with) your reasoning! So I think it boils down to what I originally proposed: Keep the core code as is with all its flexibility. If you...

> User defined adapters ignore the connection settings in the instrument, therefore it does not matter, whether it is defined as single connection or multi connection. Of course you are...

I am afraid I screws this keyword arguments somehow up. Can you try the following (with v. 1.7.6): ``` result = fitmkin.fit(ydata, params, qarray, lmfit_kws=dict(hkl=(0,0,2)), hkl=(0,0,2)) ``` (When I test...