dkpro-jwpl Fixes #24 - Automatically delete *.bin files after dump creation process

Fixes #24 - Automatically delete *.bin files after dump creation process

Open mawiesne opened this issue 6 years ago • 17 comments

Adds a "path/file deletion watch dog" which guarantees to remove files upon JVM shutdown to avoid left behind (intermediate) files
Adapts the SimpleBinaryDumpWriter implementation to register all created *.bin at the DeleteFilesAtShutdown monitor
Reduces CnP code by adding helper methods to SimpleBinaryDumpWriter

@daxenberger / @reckart Please review the changes in this branch I pushed to solve #24.

Note: This needs proper, manual testing as there isn't any JUnit test for this. This should - ideally - be tested on different OSes, i.e. Linux/Windows/MacOS and under OpenJDK/Oracle JDK 8.

Fixes #24 - Automatically delete *.bin files after dump creation process

Jul 07 '18 15:07 mawiesne

Jul 07 '18 16:07 ukp-svc-jenkins

Why not simply call File.deleteOnExit()?

Jul 08 '18 09:07 reckart

I'm not even sure that DumpWriter should really clean up after itself. What if somebody really just wants to create these files and doesn't want them to get deleted at shutdown? I thing that DumpWriter should implement some clean-up method which the code that makes use of the DumpWriter can call at the end. Then the code which makes use of the DumpWriter should be changed to call this method after it does not need the data produced by the DumpWriter anymore.

Jul 08 '18 09:07 reckart

Jul 08 '18 12:07 ukp-svc-jenkins

@daxenberger I agree: .bin files are not of much interest to most (>90%) users. Please specify an optional parameter in the original issue (#24) as a comment. I could then rework the PR to reflect this idea, so users can decide whether to keep the files or not.

Jul 09 '18 07:07 mawiesne