gnuplotlib icon indicating copy to clipboard operation
gnuplotlib copied to clipboard

Synchronization mechanism for non-POSIX

Open noc0lour opened this issue 5 years ago • 5 comments

Today I tried to run an application with gnuplotlib on a Windows machine and had to add following patches to make it start.

I still see problems with the polling as under high load the threads probably fire too late but this is a first idea how to solve synchronization for all platforms with one solution. If this not desirable (select.select is much more elegant) I'd think of modifying the synchronization so this solution is used for Windows (and other platforms which don't support select() and file objects.

noc0lour avatar Nov 26 '19 15:11 noc0lour

I still need to implement the stop & cleanup on destruction, otherwise the threads will persist over the lifetime of the object.

noc0lour avatar Nov 26 '19 16:11 noc0lour

Hi. Thanks for working on this. Before we talk about specifics of the patches, some questions:

  1. I don't use windows, so it would be on you to test stuff, and to declare it "done". And preferably I would pass any future bug reports on to you. Is that ok?

  2. Does it work for you after your patches? If not yet, then maybe we shouldn't merge anything yet. You can work in a branch until you get it running. Yes?

dkogan avatar Nov 26 '19 20:11 dkogan

To 1. for the near future this would be fine.

To 2. It's not ready to merge yet, I wanted to see if a solution like this is an option at all for you. I will definitely work on it on my own branch until it's ready.

noc0lour avatar Nov 27 '19 07:11 noc0lour

I'm investigating a weird issue where GNUplot hangs after subsequent plotting into it. And then of course gnuplotlib detects correctly that it stopped working.

noc0lour avatar Nov 27 '19 08:11 noc0lour

OK. I'm definitely interested in getting this working on more platforms, so once you get it running, ping me, and we can get this merged.

dkogan avatar Nov 27 '19 18:11 dkogan