Dmitry Kobak

Results 115 comments of Dmitry Kobak

@adrinjalali: Yes, we did discuss it. Just below the comment you linked to, @antoinebaker gave detailed reasons for why he prefers a separate class, please see here: https://github.com/scikit-learn/scikit-learn/pull/22330#issuecomment-2507657343. He convinced...

@antoinebaker Thanks. I committed all your suggestions. > However I couldn't see (and check) the rendered doc of the ClassicalMDS class in the CI. Do you see it when building...

I guess you are right! Added.

Regarding the user guide, it is already there. Regarding examples, good point, I have now added classical MDS (and also non-metric MDS) to `plot_compare_methods.py`, `plot_lle_digits.py`, `plot_manifold_sphere.py`, `plot_mds.py`. (Edit: checked the...

@adrinjalali See above -- I have added examples. Let me know if there is anything else I can do on my side.

> The nonmetric MDS seems to perform badly on S-curve and sphere (plot_compare_methods and plot_manifold_sphere). Is this an expected limitation of this method on such dataset ? Or is there...

Hi @adrinjalali, just a gentle ping to take another look here. But if you are on holidays then enjoy your holidays :-)

@adrinjalali Fair enough. I added some details, take a look if this is sufficient now.

Dear @adam2392, hope you are having a nice summer! Just a gentle reminder that it would be amazing if you could look at this PR :-) Cheers.

Dear all, as discussed above, now that this PR is merged, I prepared a follow-up PR that modifies the `MDS` class accordingly. I'll be grateful for reviews there! See #32229....