Marc Poulhiès

FTR, in the changelog, you're supposed to give extra info, not only the filename: ``` * backend/rust-compile-base.cc (HIRCompileBase::handle_inline_attribute_on_fndecl): Handle LITERAL attribute input type. ```

You must also use full issue ref, not only `#`. We need this because commits will be contributed to GCC, so a bare `#3658` will be ambiguous and will probably...

(obviously, https://github.com/Rust-GCC/gccrs/actions/runs/14523528568/job/40749776631?pr=3754 didn't work as expected...)

> > (obviously, https://github.com/Rust-GCC/gccrs/actions/runs/14523528568/job/40749776631?pr=3754 didn't work as expected...) > > would this be something I could fix in the CI so it fails properly ? probably yes :)

erm, darwin ppc (original report) is a native target without rustc support, and you're adding a cross target, still without rustc support, but it's even worse as we don't support...

> > erm, darwin ppc (original report) is a native target without rustc support, and you're adding a cross target, still without rustc support, but it's even worse as we...

FYI, changelog is not really correct. You should have things like: ``` * typecheck/rust-substitution-mapper.cc (SubstMapperInternal::Resolve): use insert_implicit_type. * typecheck/rust-typecheck-context.cc (TypeCheckContext::insert_type): Remove. (TypeCheckContext::compute_inference_variables): use insert_implicit_type. ``` ... You're not supposed to...

> > I think you need to fix your sign-off for DCO you are using a pseudonym > > https://gcc.gnu.org/dco.html > > I changed the sign-off to match the DCO....

I may be wrong, but I think you're missing the "Signed-off-by" footer (unless you've filed copyright assignment, in that case please ignore my comment) :)

We don't really care about warning outside of rust anyway. And from my recent experience of rebasing over upstream frequently, I can see how this change is needed as I've...