Dounia Khaldi

Results 25 comments of Dounia Khaldi

> By the way, I corrected a lot of typos that are still relevant for the new document here: https://github.com/intel/llvm/pull/6525/files > > Basically if you ignore the new sections I...

> I have a question about the old specification, which is now named "sycl_ext_oneapi_deprecated_matrix_no_use". Is that version of the API still supported? @gmlueck, yes, this version is still supported and...

@intel/dpcpp-specification-reviewers, any more review on this?

> How can you support both simultaneously? How does the user determine whether they get the new vs. the old API? they can do this by specifying the SYCL_EXT_ONEAPI_MATRIX feature...

>> You have this inconsistency throughout the spec. In many places, you refer to the three matrices as a, b, and c. However, the use enum refers to them as...

> Whenever you rename (or move) a specification, you should search the repo and see if there are any links to the old name. In your case, there are several...

@intel/dpcpp-doc-reviewers, any more reviews on this? It will be good if we can merge this ASAP.

@intel/dpcpp-doc-reviewers, can you please help merge this if there are no more comments?

> @dkhaldi, please move deprecated extension to https://github.com/intel/llvm/tree/sycl/sycl/doc/extensions/deprecated done

@intel/dpcpp-doc-reviewers, please help merge.