keeperfx icon indicating copy to clipboard operation
keeperfx copied to clipboard
verified publisher icon dkfans

Edit french translation about traps (minor changes)

Open walt253 opened this issue 1 year ago • 2 comments

I don't like current french translation for current custom string of custom traps.

walt253 avatar Jun 28 '24 22:06 walt253

I would like to ask AncientWay for a review but I'm not sure of their username here on github. 🤔

walt253 avatar Jun 28 '24 23:06 walt253

I pointed him in the direction of this PR yesterday and he would check after the weekend.

Loobinex avatar Jun 30 '24 16:06 Loobinex

I would like to ask AncientWay for a review but I'm not sure of their username here on github. 🤔

Hello, I agree with all your changes, except one slight modification perhaps on the "Spitfire Trap". I added a comment in the code (sorry I'm very noob with github)

AncientWay avatar Jul 02 '24 19:07 AncientWay

I would like to ask AncientWay for a review but I'm not sure of their username here on github. 🤔

Hello, I agree with all your changes, except one slight modification perhaps on the "Spitfire Trap". I added a comment in the code (sorry I'm very noob with github)

Thanks, updated based on your feedback.

walt253 avatar Jul 04 '24 13:07 walt253