keeperfx
keeperfx copied to clipboard
External speeches for Adam
Also, volume is set when it is played. Before it was determined when the script was loaded.
Will this affect non-speech external sounds?
Will this affect non-speech external sounds?
I did 2 fixes:
- SPEECH should now play with the speech volume, not the sound volume. So only changes speeches
- All external sounds now have the volume set once they are played, not once the script is loaded. This affects all external sounds yes.
https://github.com/dkfans/keeperfx/blob/214ee4d076661d925b45a74e870a2eb5f7009dc9/src/frontmenu_options.c#L319
Is this still needed?
Edit: It also looks like it changes all external sounds.
Edit 2: It actually is needed (and needs to be fixed) if we want speeches to change volume immediately. Unfortunately, I don't think we record whether it's a sound or a speech anywhere...