keeperfx icon indicating copy to clipboard operation
keeperfx copied to clipboard

add pre-commit, define Clang format and refactor codebase

Open QuantumRiftwalker opened this issue 1 year ago • 4 comments

QuantumRiftwalker avatar Nov 18 '23 00:11 QuantumRiftwalker

I think all script levels (TXT) and config files (CFG) should be excluded from this?

walt253 avatar Nov 18 '23 17:11 walt253

I think all script levels (TXT) and config files (CFG) should be excluded from this?

Maybe but it might be useful to remove trailing whitespace in these files too.

QuantumRiftwalker avatar Nov 20 '23 01:11 QuantumRiftwalker

I think all script levels (TXT) and config files (CFG) should be excluded from this?

Maybe but it might be useful to remove trailing whitespace in these files too.

Sometimes it's maybe done on purpose? for example:

image

What do people think about this? I don't know, I'm not trying to dismiss anything, I'm all for a more readable code but text and cfg files should really be treated differently, I think?

walt253 avatar Nov 20 '23 12:11 walt253

I think all script levels (TXT) and config files (CFG) should be excluded from this?

Maybe but it might be useful to remove trailing whitespace in these files too.

Sometimes it's maybe done on purpose? for example:

image

What do people think about this? I don't know, I'm not trying to dismiss anything, I'm all for a more readable code but text and cfg files should really be treated differently, I think?

I would have thought that that would be treated as empty/null still? If not, you raise a good point then.

QuantumRiftwalker avatar Nov 20 '23 19:11 QuantumRiftwalker