keeperfx icon indicating copy to clipboard operation
keeperfx copied to clipboard

Added FLASH_NEUTRAL_ROOM_COLOURS config option

Open AdamPlenty opened this issue 1 year ago • 9 comments

AdamPlenty avatar Nov 12 '23 20:11 AdamPlenty

Tested it to work, but is white really the best color here? I see it is brighter than regular hero stuff, but I still think people might get confused. What would you think of a dark brown?

Loobinex avatar Nov 13 '23 00:11 Loobinex

Tested it to work, but is white really the best color here? I see it is brighter than regular hero stuff, but I still think people might get confused. What would you think of a dark brown?

I only used white for consistency with the level previewers (both the DKTools ones and my own). Without seeing it, I reckon dark brown could be mistaken for dirt path.

AdamPlenty avatar Nov 13 '23 00:11 AdamPlenty

Tested it to work, but is white really the best color here? I see it is brighter than regular hero stuff, but I still think people might get confused. What would you think of a dark brown?

I only used white for consistency with the level previewers (both the DKTools ones and my own). Without seeing it, I reckon dark brown could be mistaken for dirt path.

The previewers aren't really something the majority of players are familiar with at all.

But this is you: image

This is with a brown from the palette: image

Loobinex avatar Nov 13 '23 00:11 Loobinex

Hmm... 🤔

The neutral next to the hero could be mistaken for some other terrain, I reckon.

AdamPlenty avatar Nov 13 '23 03:11 AdamPlenty

Would it be possible to keep the flashing, but make it flash slowly instead? That way surely it does not hurt the eyes of the people it bothers now.

Loobinex avatar Nov 13 '23 10:11 Loobinex

Would it be possible to keep the flashing, but make it flash slowly instead? That way surely it does not hurt the eyes of the people it bothers now.

Yeah i was thinking the same. Maybe making the interval configurable:

FLASH_NEUTRAL_INTERVAL=5

I think the default is 1 or 2 turns between each color switch?

yani avatar Nov 13 '23 15:11 yani

Would it be possible to keep the flashing, but make it flash slowly instead? That way surely it does not hurt the eyes of the people it bothers now.

I'm not sure 🤔. The game looks at the game turn anded by 3.

AdamPlenty avatar Nov 14 '23 18:11 AdamPlenty

color = (turn - (turn % frametime))/frametime % 4 that should allow you to set the frametime

PieterVdc avatar Nov 15 '23 16:11 PieterVdc

color = (turn - (turn % frametime))/frametime % 4 that should allow you to set the frametime

Where would timeframe be specified? This new setting?

AdamPlenty avatar Nov 16 '23 02:11 AdamPlenty