keeperfx icon indicating copy to clipboard operation
keeperfx copied to clipboard

Psycho creatures can no longer be cheered up

Open AdamPlenty opened this issue 2 years ago • 2 comments

Resolves #386

AdamPlenty avatar Jun 03 '22 16:06 AdamPlenty

I have tried reproducing the issue before your fix first, and am having trouble there. Without this PR, can you still reproduce the issue of livid horned reaper being not-angry? And if so, how?

I used cheats to test this, but I'm pretty sure it's possible via normal means to make psycho Horned Reapers happy again.

AdamPlenty avatar Jun 07 '22 00:06 AdamPlenty

Then how? I tried with gold, with temple, with standing on corpses,...

Loobinex avatar Jun 07 '22 10:06 Loobinex

My wife ran into this problem. Here are her savefiles for an active game where two horned reapers can't be cheered up in the temple. These are her notes:

This Dungeon Keeper saved file has two horned reapers who cannot be made happy. They sometimes laugh if you give them gold but their happy meter doesn't change. They won't stay in the temple but if you turn on the Must Obey spell they will stay in the temple but do not get happy.

DK error.zip

LummoxJR avatar Nov 13 '22 21:11 LummoxJR

@LummoxJR Horned Reapers are supposed to go mad with anger so that they can never be cheered up. Adam says he fixed a bug where he CAN make them happy, which I have not been able to reproduce yet.

Loobinex avatar Nov 13 '22 23:11 Loobinex

Horned Reapers could always have been made happy; it just didn't remove the MAD_PSYCHO job. It makes no sense for a Horned Reaper to be psycho yet happy.

AdamPlenty avatar Nov 13 '22 23:11 AdamPlenty

I believe in the original game, part of being Psycho was that his happiness bar dropped back to 0 right away too. In KeeperFX this was weird for a while that he seemed happy again. But that has been solved for quite a while now.

@AdamPlenty It's the function anger_free_for_anger_decrease that stops reapers from becoming happy in the current master.

Loobinex avatar Nov 13 '22 23:11 Loobinex

Okay, I think I might be confused because I was thinking this was a bug report and not a fix to one. My wife played the original game for years and years, and is only very recently using KeeperFX since she couldn't play it for the longest time except on an old Windows 98 machine. Per what she described to me, it ought to be possible to cheer up the horned reaper again. I'll check back in with her, but she's telling me the behavior has definitely changed from the original game.

LummoxJR avatar Nov 14 '22 07:11 LummoxJR

It's possible to cheer the Horned Reaper up again, but he'll still be psycho, no matter what.

AdamPlenty avatar Nov 14 '22 07:11 AdamPlenty

It's possible to cheer the Horned Reaper up again, but he'll still be psycho, no matter what.

How do you think it's possible?

Loobinex avatar Nov 14 '22 12:11 Loobinex

Okay, I think I might be confused because I was thinking this was a bug report and not a fix to one. My wife played the original game for years and years, and is only very recently using KeeperFX since she couldn't play it for the longest time except on an old Windows 98 machine. Per what she described to me, it ought to be possible to cheer up the horned reaper again. I'll check back in with her, but she's telling me the behavior has definitely changed from the original game.

In the original game, once the reaper went mad, he could never be turned back to normal again. This has always been the defining feature of the reaper.

Loobinex avatar Nov 14 '22 12:11 Loobinex

Okay, I think I might be confused because I was thinking this was a bug report and not a fix to one. My wife played the original game for years and years, and is only very recently using KeeperFX since she couldn't play it for the longest time except on an old Windows 98 machine. Per what she described to me, it ought to be possible to cheer up the horned reaper again. I'll check back in with her, but she's telling me the behavior has definitely changed from the original game.

O, what is different from the original game, is how cheap it is to make annoyed units happy again. Units can be annoyed, or angry enough to do their anger job. Anger jobs are destroying walls, killing units, changing player, or in the case from Horny it's going Psycho. Going psycho is killing friendlies and never returning to normal ever again.

However, before he goes 'mad', he can still be cheered up, as can all other units. In the original game, just dropping a single piece of gold on the unit would reset the happiness level back to full. This has been fixed in KeeperFX, and now the unit gets a bit of happiness back and it depends on how much gold you give and the personality of the unit type. It's really expensive to make expensive units like vampires or reapers happy again this way. If a horned reaper is starting to get angry, but is not yet killing your own units, make him pray in the temple to cheer him up.

Loobinex avatar Nov 14 '22 12:11 Loobinex

Closed due to info not coming. May be reopened if I was mistaken after all.

Loobinex avatar Sep 05 '23 23:09 Loobinex