CRNotifications icon indicating copy to clipboard operation
CRNotifications copied to clipboard

make title, message optional.

Open MoElnaggar14 opened this issue 4 years ago • 2 comments

add UIStackView that contain titleLabel, messageLabel to handle nil or empty title, message

MoElnaggar14 avatar Mar 24 '20 11:03 MoElnaggar14

@dkcas11 please, can you check this PR?

MoElnaggar14 avatar May 08 '20 10:05 MoElnaggar14

There is simply too big of a change in the API to consider this PR at its current state. Most of the stuff has recently been added by request of other users so this will be a breaking change in many ways. It seems like this serves a very specific use case rather than appealing to a broader audience. In regards to the amount of displayed text this has already been discussed a few times, such as here: https://github.com/dkcas11/CRNotifications/issues/6 Im sorry, but i think its best to fork the repo and adjust the implementation for your needs and embed the framework from there :-)

dkcas11 avatar May 13 '20 13:05 dkcas11