Daniel Karrasch
Daniel Karrasch
The deprecated ITensorsGaussianMP.jl fails, but its up-to-date version in ITensors.jl seems to pass. Let's look at that specifically. I wonder why ITensors.Circuit actually subtypes `AbstractRotation`, if all methods are provided...
Since, after all, this doesn't seem to break any code, I'll merge in a few days if no objections arise. This part of the code seems to be mainly used...
It should probably be ```julia g!(out, a, b) = mul!(out, a + b, (a * b)') ```
I guess this would also fix the following issue: ``` using Distances, BenchmarkTools x = rand(100); y = rand(100); @btime evaluate($(Euclidean()), $x, $y) # 24.176 ns (0 allocations: 0 bytes)...
I think that along the same lines, one could have a single interface for all `UnionMetrics`, including the weighted/periodic ones? By including the extra info as a type parameter, we...
Sure, all metrics in the package are written by someone, they are not magically built in Julia. So you can closely follow the examples written here. Generally, you will need...
That's possible. You first `import Distances` or `using Distances` in your package, and then define the `struct` and the `evaluate` instance. In the first case, you will need to add...
There is one more detail: you will need to explicitly import those methods from `Distances.jl` that you wish to extend/overload, so `import Distances: evaluate` for example, but Julia will tell...
This has been proposed earlier, but it is somewhat controversial. The 3-arg `dot` has specializations for structured matrices and outperform the 2-arg `dot` with product in small cases. Unfortunately, for...