gelli
gelli copied to clipboard
dkanada
Add support for multiple artists
In response to feature request #198.
This makes it necessary to differentiate between artists and album artists so I created an album artist fragment. The assumption is that at most one albumartist is set but multiple artists in the artist tag are possible.
I also added a GetSearchHintsAsync call to the search activity because GetItemsAsync will not return artists with no albums. GetSearchHintsAsync does not work well with albums though so I split the search into two calls, GetSearchHintsAsync for artists and GetItemsAsync for albums and songs. There might be a better way to do this but this is the only way I could make it work. This should solve issue #176.
Haven't looked through everything yet but I'll review and merge in the next week or two. I'm guessing that the "Go To Artist" button on a song will send people to the album artist, and the same goes for the artist button in the album details view. Let me know if you have any other features planned and I'll make sure to include them in the same release!
Yes, the various "go to artist" links will still go to the album artist.
There's currently no way to go to individual artists' pages for songs from compilation albums, maybe there should be? Maybe I'll think of a way to implement this and do a further pull request in the future but this one should suffice for now.
What I would personally really like to see is artist names for songs in the album view and also in the song queue. For album views it might be sufficient to show individual artists only whenever the artist tag differs form the album artist tag. But the song queue should always show the artist in addition to the album to be more informative imho. Shouldn't be too hard to implement, I will look into it.
I've been looking into adding chromecast capabilities but haven't gotten very far. I'm still learning how to even do this.
Did you test upgrading an existing install with these changes? Just want to make sure the database doesn't need any migrations because I've seen that issue before.
It's been a while, I'll try upgrading from the current release again later today and let you know. Given that the Song model had to be changed to support an ArrayList for artistId and artistName I'm guessing there might be some issues. Is there anything that can be done to alleviate potential upgrade problems? If it's necessary, I'll look into Room database migration and try to add it to this pull request.
@bgaesslein Have a look at this for db migrations. For every model you change, you need to drop/recreate or alter the respective table.
