frost icon indicating copy to clipboard operation
frost copied to clipboard

code changes

Open dkanada opened this issue 4 years ago • 10 comments

@Donnnno I made some changes to the code that might be useful in your app as well. If you want to convert the ic_* icons to SVGs I can also update the menu to better support color changes in the future.

dkanada avatar Dec 28 '20 04:12 dkanada

That sounds pretty cool! I'll take a look if I can implement your changes, can you explain what it precisely does?

Btw, there's someone who's gonna take a look at a search feature for the app, that might be useful for you too :)

Donnnno avatar Dec 28 '20 20:12 Donnnno

@dkanada also a small question: Do you know if F-Droid auto-detects GitHub releases? Or do I have to notify it somewhere?

Donnnno avatar Dec 29 '20 14:12 Donnnno

It was a bunch of minor stuff like improving the build configuation, fixing some duplicate strings, and pulling the button styling out into a custom element so we don't need half a page for every single button. There's still way too much code for the interface but this should at least improve things. I'll have another commit soon with more code reduction.

dkanada avatar Dec 29 '20 14:12 dkanada

I think it detects the tags, not the releases.

dkanada avatar Dec 29 '20 14:12 dkanada

Ah okey, I think I did it right then :) thanks

Donnnno avatar Dec 29 '20 14:12 Donnnno

I've implemented your code, it looks pretty good :)

Donnnno avatar Dec 30 '20 19:12 Donnnno

also how does the raster script work? I'm getting an error (I have inkscape installed). raster.sh: line 17: inkscape: command not found

Donnnno avatar Dec 30 '20 19:12 Donnnno

What distro are you using? I wrote these scripts back when I was using sh to run tools instead of bash so I think there are some quirks due to that decision. Otherwise, I would guess it's a PATH issue for the Inkscape binary, which is unrelated to the script itself.

dkanada avatar Dec 31 '20 06:12 dkanada

Ah okey, I'm using windows with git bash to run the other scripts. But if it doesn't work I always can use the illustrator export options instead (it takes more time to do it that way).

Donnnno avatar Dec 31 '20 06:12 Donnnno

@dkanada A friend of mine added a search function to the app, might be useful for you as well :)

Donnnno avatar Jan 05 '21 22:01 Donnnno