GIthub Actions

Open ejiektpobehuk opened this issue 5 years ago • 4 comments

I'm planning to play a bit with github actions and it could be helpful for our PR system by introducing automated checks.

The question is what should we check? I've came up with a next list:

no colours other than white (#ffffff or #FFFFFF)
no transparency
no transform
no gradient

I'm interested in suggestions on what to add or delete to/from this list :ear:

Mar 19 '20 07:03 ejiektpobehuk

I think we would already have issues with the transform rule because I saw some floating around in the icon folder, but those sound like excellent checks!

Mar 19 '20 08:03 dkanada

I always use a minifier with VS Code to remove all unneccesary stuff from my svg files. Which also minifies #ffffff to #fff so please keep that in mind.

Apr 22 '20 21:04 douweschulte

That shouldn't be too important, don't worry.

Apr 23 '20 03:04 dkanada

https://github.com/scour-project/scour looks promising

May 13 '20 22:05 ejiektpobehuk