sqlakeyset icon indicating copy to clipboard operation
sqlakeyset copied to clipboard

Published 20 hours ago • verified publisher icon djrobstep

Implement get_homogeneous_pages and select_homogeneous_pages

Open mattalbr opened this issue 1 year ago • 6 comments

The select version was super challenging to write, but we made it. Lots of type wrangling to get the query to work with orm entities. Doesn't work in 1.3, but neither does select(Book, Book.id) with a normal page. Figure it's probably pretty rare to be using select() and 1.3 anyway.

mattalbr avatar Jul 18 '23 22:07 mattalbr

AFAIK using select with ORM entities was never officially supported in 1.3, so I think we're good there :) I'd be perfectly happy with restricting new features to sqlalchemy 1.4+ or even 2+ anyway.

Full review coming soon when I have the time, thanks again :)

acarapetis avatar Jul 20 '23 23:07 acarapetis

Just wanted to follow up @acarapetis for a review when you have the chance! Thanks!

mattalbr avatar Aug 07 '23 18:08 mattalbr

@mattalbr Sorry for the delay on this, been a bit swamped. Hopefully will have time this weekend!

acarapetis avatar Aug 24 '23 03:08 acarapetis

Any updates to this?

ddorian avatar Sep 12 '23 10:09 ddorian

Hi Anthony, just wanted to ping here to see if you'll have time to review coming up!

mattalbr avatar Sep 27 '23 22:09 mattalbr

Hi @acarapetis, picking this back up, is there any way to get a review from you on this PR?

mattalbr avatar Apr 16 '24 21:04 mattalbr