schemainspect icon indicating copy to clipboard operation
schemainspect copied to clipboard

Published 20 hours ago • verified publisher icon djrobstep

Add support for roles.

Open bdamian opened this issue 5 years ago • 2 comments

bdamian avatar Jan 10 '20 11:01 bdamian

Thanks for this and the other pull requests, looks like great stuff. I'll try to get to reviewing them in more detail as soon as I can and get them merged.

How would you feel about adding some tests? I'm hesitant to merge code that doesn't have some test coverage.

djrobstep avatar Jan 15 '20 03:01 djrobstep

First, thanks for your interest!

I agree about tests. I'll prepare some, also for the other pull requests.

bdamian avatar Jan 15 '20 10:01 bdamian