dwl icon indicating copy to clipboard operation
dwl copied to clipboard

increase the limit of SLOC

Open sevz17 opened this issue 2 years ago • 6 comments

We are running out of lines (at b04c73be3de62d2739b5bb85e40f0c9af1122903 tokei reports exactly 2000 SLOC)

So the question is: does anyone really need it?

sevz17 avatar Jul 24 '22 20:07 sevz17

I like to have my windows ask for attention in a simple fashion, without having to go through a heavyweight or intrusive notification manager. The urgency hint has always been the way dwm handles it, quietly highlighting the tag(s) of a window requesting attention.

djpohly avatar Jul 26 '22 15:07 djpohly

On discord some users also disagree with this...

@djpohly we need to increase the limit of SLOC, even with wlroots we need to handle things that dwm don't have to, i.e create two types of clients (layer shell and normal clients (xdg and xwayland), implement protocols analogous to those provided by the X server, etc. and another thing I think we really should support is touch...

sevz17 avatar Aug 04 '22 04:08 sevz17

@sevz17 what's the use case for touch support because I don't get why we need touch in a tiling WM?

pm4rcin avatar Aug 04 '22 09:08 pm4rcin

I'm not against increasing the SLOC limit, but it's there so we make careful decisions about what is in mainline and what is a patch. Touchscreen support feels like patch territory to me. If you consider all the systems that might run dwl, there may be many with touchscreens, but I wouldn't say it's the vast majority. (I'm writing this from a laptop with a touchscreen, so it's not because I wouldn't use it!)

Is there something more universally applicable being held back by the SLOC cap?

djpohly avatar Aug 04 '22 22:08 djpohly

I'm not against increasing the SLOC limit, but it's there so we make careful decisions about what is in mainline and what is a patch. Touchscreen support feels like patch territory to me. If you consider all the systems that might run dwl, there may be many with touchscreens, but I wouldn't say it's the vast majority. (I'm writing this from a laptop with a touchscreen, so it's not because I wouldn't use it!)

Is there something more universally applicable being held back by the SLOC cap?

I think that https://github.com/djpohly/dwl/pull/226 is universal and should be implemented. And that's definitely held back.

pm4rcin avatar Aug 05 '22 08:08 pm4rcin

Is there something more universally applicable being held back by the SLOC cap?

I think mainly getting wlr-randr working, correctly implementing the idle inhibit protocol, ext-session-lock and general bug fixes (eg https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3653 , etc.)

sevz17 avatar Aug 09 '22 02:08 sevz17