Joel de Guzman comments

Results 505 comments of


                                            Joel de Guzman

X3 Parser operators page missing actual code

Thanks for telling me.

`x3::ascii::string()` and `x3::iso8859_1::string()` param types are wrong

Do you have some use cases you can share that reinforces what you are trying to point out? Use cases, esp. those that present some errors or problem points, should...

`x3::ascii::string()` and `x3::iso8859_1::string()` param types are wrong

> Thanks for your time, and libraries, Joel! Most welcome! Hey, can you make that into an MVCE? I think you are onto something, but I think more clearly when...

support nothrow expect

What's the reason for using -O2 instead of -O3? Can you provide a benchmark test program that we can try that shows these numbers? How about other compilers, e.g. g++?

support nothrow expect

Also, if you are going to just fail the parse anyway, what's the advantage of using a > b instead of just a >> b ?

support nothrow expect

Looks good to me. I'll need some time to try and study the example code.

support nothrow expect

OK, the speed issue is really disconcerting. On one hand this fix is a step in the right direction. On the other hand, previous code using the throw can't take...

support nothrow expect

Option 3 sounds good. I'm not sure I understand "users have to be careful when writing user defined parser structs"... could you elaborate a bit with an example, like the...

support nothrow expect

OK, I like option 3. This one needs documentation though. Are you willing to go all the way and include documentation updates? Many thanks!

support nothrow expect

I might be missing something here. This is a major change and can definitely affect current users' code. I think the code should therefore be optional, using a preprocessor macro,...