Symfony-coding-standard icon indicating copy to clipboard operation
Symfony-coding-standard copied to clipboard

Published 20 hours ago • verified publisher icon djoos

Duplicate ScopeClosingBraceSniff

Open CarsonF opened this issue 7 years ago • 3 comments

PSR2 imports Squiz.WhiteSpace.ScopeClosingBrace. Zend imports PEAR.WhiteSpace.ScopeClosingBrace.

It's hard to tell which one is better. I'm leaning towards keeping the one in PSR over Zend though.

CarsonF avatar Jul 28 '17 15:07 CarsonF

thanks for your input @CarsonF !

there are more duplicates (ClassDeclaration.MissingBrace, ScopeClosingBrace.indent to name a few)

it's not that this blocks phpcs from running nor that either of them is raising false positives. in the end the violation needs to be fixed and after that both approve.

could you elaborate why we need to disable one of both?

wickedOne avatar Jul 28 '17 18:07 wickedOne

Yes you are right. It just makes it a bit harder to sort through the list of errors in the report summary. I wouldn't have brought it up if it wasn't a simple one liner to disable the rule - I can PR if you want :smile:

CarsonF avatar Jul 29 '17 00:07 CarsonF

yes, feel free to create a PR (personally i'd keep the PSR2 as well).

wickedOne avatar Jul 29 '17 07:07 wickedOne