Donal McBreen

Results 171 comments of Donal McBreen

@eric1234 - supporting IPv6 would be great, thank's for the great write-up of the issues! We'll definitely accept fixes for this. If we don't include the square brackets in servers,...

@JoeKaldas - the context will be on the machine you are deploying from. To fix this, we need to add a check in the build step to confirm the context...

Duplicate of https://github.com/basecamp/kamal/issues/90

Closing as we've removed `kamal envify` in Kamal 2.

Hi @nickhammond! Yes that sounds great, let's give it a go!

Thanks @nickhammond! Sorry for the delay here, I've been away for the last couple of weeks. @seanmitchell - could I get your thoughts here? 🙏

@guillaumebriday - could you add a warning about this only working for single servers?

@fractaledmind - I've just tried this out on Campfire and it looks good. We are currently using a retry with backoff, but I'm not seeing any performance differences with our...

@fractaledmind - my concern would be where you have a lot of threads/processes all waiting to get a lock and a single thread that is holding on to the transaction...

@fractaledmind - thanks for that! I've tried out your script with some adjustments - 1. do everything in one process so all the threads are all contending for the GVL,...