Metronome icon indicating copy to clipboard operation
Metronome copied to clipboard

Published 20 hours ago • verified publisher icon djipco

Fixed RTE When Stopping

Open brianmriley opened this issue 9 years ago • 1 comments

  • It was previously possible to call stop() without actually starting the Metronome. We still allow the stop() call, but we make sure the referenced objects exist (to fix the RTE).
  • If trying to stop() and the Metronome is not running the only thing that really happens is setting the property _samplesBeforeTick back to zero (so basically resetting the object. If, however, the _soundChannel is available we stop that well. If running we dispatch the stop event as well.
  • Added IntelliJ Module config file.

brianmriley avatar Jun 11 '15 00:06 brianmriley

Wow! It seems I completely missed this PR when you submitted it. By chance, I just stumbled upon it now... more than 2 years later! I'm so sorry about this.

Anyway, I would glady merge it if it weren't for the .iml file which I'm no sure should be checked in.

djipco avatar Jan 04 '18 06:01 djipco