Onboard-SDK-ROS icon indicating copy to clipboard operation
Onboard-SDK-ROS copied to clipboard

Get Avoid Enable Status bug

Open vicmassy opened this issue 4 years ago • 2 comments

Dear DJI,

When you try to call the service /get_avoid_enable_status to obtain the current status of the avoidance system you get the following:

result: True                                                                                       
horizon_avoid_enable_status: 0                                                        
upwards_avoid_enable_status: 0 

And if I enable just the horizon_avoid with rosservice call /robot119/set_horizon_avoid_enable "enable: true" and check again the status I get:

result: True                                                                                        
horizon_avoid_enable_status: 1                                                                   
upwards_avoid_enable_status: 1

So I found out in the code that when you check for the status of the avoid system, you return the status of the horizontal avoid for the upwards avoid. You can find the exact line here:

https://github.com/dji-sdk/Onboard-SDK-ROS/blob/b7aa9f3bf2d07eb1da3b5768aba4816bcfd2683b/src/dji_osdk_ros/dji_vehicle_node.cpp#L1751

In my opinion it should be something like:

response.upwards_avoid_enable_status = get_upwards_avoid_enable_status

I opened a PR #490 to solve the issue

vicmassy avatar Dec 07 '21 08:12 vicmassy

Agent comment from DJI SDK in Zendesk ticket #57481:

尊敬的开发者,感谢您联系DJI 大疆创新 由于github不是我们主要的咨询渠道,您的问题可能跟进不及时。我们建议您通过填写表单( https://djisdksupport.zendesk.com/hc/zh-cn/requests/new )向我们反馈问题。或者您也可以在论坛发帖,与其它开发者交流。论坛链接:https://djisdksupport.zendesk.com/hc/zh-cn/community/topics

Dear developer, thank you for contacting DJI. Since github is not our main consultation channel, your questions may not be followed up in time. We recommend that you fill in the form (https://djisdksupport.zendesk.com/hc/en-us/requests/new) to report problems to us. Or you can post in the forum to communicate with other developers. Forum link: https://djisdksupport.zendesk.com/hc/zh-cn/community/topics

°°°

dji-dev avatar Dec 07 '21 08:12 dji-dev

Agent comment from kyle.cai in Zendesk ticket #57481:

Dear developer ,

Thank you for contacting DJI.

Thanks for your feedback. We have submitted this issue.

Thank you for your understanding and support, hope you have a nice day.

Best Regards, DJI SDK Support Team

°°°

dji-dev avatar Dec 07 '21 12:12 dji-dev