Joseph Lombrozo

Results 44 comments of Joseph Lombrozo

That's a fair point re: plaintext, although I don't think we can control whether people have set up argocd in a way that requires it. Invalid certificates are going to...

Yeah, that does look like a valid issue. Shallow checkouts were done to avoid the full cloning of large repositories, but issues like this lead me to believe that we're...

Ah, nope, I suspect that this is still not supported. Something worth adding though!

If you're using github auth, is there any reason to avoid generating a jwt for all clones, not just public repos? If I understand correctly, the generation is done offline,...

I got a few issues resolved while testing #423 , but just found that the jwt is relatively short lived (8 hours), so that'll have to be updated on a...

After looking at the difference between slog and zerolog, we'd be losing a bunch of functionality to remove the dependency: hooks, integrations, Trace and Fatal, etc. Unless you feel strongly...

It looks like this might not be implemented. It was added [here](#288), but seems either it broke or simply never worked. Or accidentally worked? Looks like we use the github...

After reviewing, @ValentaTomas pointed out that Idx is used to generate IP addreses, which must not overlap across orchestrators on the same host. I'll need to do some more work...

I'm going to pull a piece out to its own PR, and reopen when that's merged.