mu icon indicating copy to clipboard operation
mu copied to clipboard

add thread fold/unfold

Open zabbal opened this issue 11 years ago • 10 comments

Ability to fold/unfold thread via single click and hotkey will make UI much cleaner and convenient to use - especially in case of ML where long heated threads are not uncommon thing.

zabbal avatar Oct 15 '12 14:10 zabbal

+1 to this. Arbitrary folding would be awesome (something along the lines of gmail where previously read messages in a thread are folded automatically)

seanfarley avatar Mar 21 '13 21:03 seanfarley

I was wondering where this is at and if I can help complete this. Do we have a good idea on the strategy to employ for this feature?

sachdevaprash avatar Sep 08 '16 00:09 sachdevaprash

@sachdevaprash please follow #783

zakkak avatar Jan 25 '17 16:01 zakkak

https://gitlab.com/ambrevar/mu4e-conversation - this seems to be related.

zabbal avatar Oct 28 '20 00:10 zabbal

Damn, this notification really got my hopes up. Much like the rest of 2020, it was a disappointment.

seanfarley avatar Oct 28 '20 05:10 seanfarley

Pardon, wasn't my intention to give false hopes :)

There's incomplete implementation in PR#783 and there's rather complete implementation of a related thing in mu4e-conversation - I don't know enough elisp to bring those together but some ideas in the latter (using org-mode code for folding for example) seem like they could be useful to fill in gaps in the former.

zabbal avatar Oct 28 '20 09:10 zabbal

I think the two features are orthogonal: this issue is, to my understanding, about folding a thread in the header view (something similar to what notmuch does). mu4e-conversation implements threading in the main view (the body of the emails). Both are useful, for sure, but I'm more interested in folding threads in the header view.

seanfarley avatar Oct 28 '20 18:10 seanfarley

The headers view is quite complicated already, I think it would benefit from being split in a generic tree-view-like widget, and then the mu4e-specific logic.

Perhaps something like https://github.com/kiwanami/emacs-ctable or something else.

djcb avatar Oct 28 '20 22:10 djcb

That makes sense, @djcb. I assume the goal would be something like emacs-ctable would handle the folding, correct?

seanfarley avatar Oct 28 '20 23:10 seanfarley

I've setup a small project at https://github.com/rougier/mu4e-thread-folding for folding/unfoldong threads in headers view. It is based on overlay. Note this is not foolproof, but usable until the ctable version. One problem is with (mu4e~headers-get-thread-info msg 'thread-id) that does not seem to return a unique id when there are a lot of thread.

rougier avatar Dec 14 '20 18:12 rougier

Thread-folding has been merged in master, so finally closing this.

djcb avatar Apr 23 '23 11:04 djcb

This is huge! Thank you @djcb, @zabbal, @rougier!

stefanv avatar Apr 23 '23 16:04 stefanv

Thread-folding has been merged in master, so finally closing this.

Thanks! but how to use it and from which version? Since the message came from "Apr 23, 2023", I think 1.10.7 should contain it, but I'm not sure how to use it.

zhihuiFan avatar Feb 09 '24 22:02 zhihuiFan

Thread-folding has been merged in master, so finally closing this.

Thanks! but how to use it and from which version? Since the message came from "Apr 23, 2023", I think 1.10.7 should contain it, but I'm not sure how to use it.

Ah, no, see https://github.com/djcb/mu/blob/master/NEWS.org It'll be in the next stable release (1.12).

djcb avatar Feb 10 '24 05:02 djcb