bb8 icon indicating copy to clipboard operation
bb8 copied to clipboard

Set MSRV to 1.56 for now

Open djc opened this issue 2 years ago • 2 comments

djc avatar Aug 01 '22 09:08 djc

Codecov Report

Merging #134 (d965f10) into main (92306cb) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   78.95%   78.95%           
=======================================
  Files           7        7           
  Lines         689      689           
=======================================
  Hits          544      544           
  Misses        145      145           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92306cb...d965f10. Read the comment docs.

codecov[bot] avatar Aug 01 '22 09:08 codecov[bot]

@nyurik do you know what might be going on with the CI failure here?

djc avatar Aug 01 '22 09:08 djc

@djc the MSRV must be set to 1.58, not 1.56. That's the first version with inline format strings. See https://github.com/djc/bb8/pull/125#issuecomment-1149072876

nyurik avatar Aug 03 '22 01:08 nyurik