djangoproject.com icon indicating copy to clipboard operation
djangoproject.com copied to clipboard

Restored search hotkey for desktop.

Open sarahboyce opened this issue 1 month ago • 1 comments

Fixes https://github.com/django/djangoproject.com/issues/2349

I also added playwright to have a way to test JavaScript (might be controversial and can remove if wanted)

sarahboyce avatar Nov 24 '25 13:11 sarahboyce

I wonder if there's a way to achieve the same behavior with a single element and responsive styling. Do you or others think this is worth pursuing?

I originally tried doing this but found it challenging. The search bar duplication aligns with the light/dark mode toggle duplication and show/hide behavior, aligning to that was easier to acheive given the existing html structure

sarahboyce avatar Nov 24 '25 16:11 sarahboyce

I'll try to take another look at this by the end of the week.

adamzap avatar Dec 17 '25 21:12 adamzap

I'd like to defer to others on this PR if someone is available to review. I'm unsure about the changes around template tags and would like to assess the difficulty of removing the duplicate navigation elements.

adamzap avatar Dec 21 '25 03:12 adamzap

assess the difficulty of removing the duplicate navigation elements.

I think the way our navigation is designed, duplicating actually makes the most sense. Without duplication, the CSS would be a little complicated / fiddly. I do think that the template tags and non-duplicating ids is slightly complicated, but I think till we have any better solution (and maybe at some point a redesign changes the entire UI anyways), this PR can be merged to at least fix the bug. @adamzap what do you think?

SaptakS avatar Dec 22 '25 08:12 SaptakS