djangoproject.com icon indicating copy to clipboard operation
djangoproject.com copied to clipboard

Docs have incorrect links to source.

Open smithdc1 opened this issue 5 months ago • 2 comments

A ticket has been opened on trac #36450 where the issue is that the [source] links in the docs have incorrect line numbers.

I've checked out main and 5.2 locally and built the docs. These generate the correct links back to the source code on GitHub.

All versions of the docs since 5.1 (the version where the switch to link to github source was made) seem to be using the same line number.

Looking at some timelines.

3rd March -- Commit which changed the line number for sum() https://github.com/django/django/commit/4b977a5d7283e7ca51288cc0ed0860e0004653ca 12th March -- 5.1 has correct link: https://web.archive.org/web/20250312194141/https://docs.djangoproject.com/en/5.1/ref/models/querysets/ 17th March -- 5.1 has incorrect link https://web.archive.org/web/20250317143719/https://docs.djangoproject.com/en/5.1/ref/models/querysets/

During this period some changes were made to the global state of Sphinx.

https://github.com/django/djangoproject.com/pull/1983 https://github.com/django/djangoproject.com/pull/1984

I'm guessing it's these commits which resulted in the change of behaviour?

cc @sarahboyce

smithdc1 avatar Jun 10 '25 09:06 smithdc1