djangoproject.com icon indicating copy to clipboard operation
djangoproject.com copied to clipboard

[UI bug] Irrelevant Space In Home Page

Open SrisailamKakurala opened this issue 1 year ago • 5 comments

https://github.com/user-attachments/assets/8935bee9-bdeb-4c8c-86a5-fe248cb1db43


Description: unnecessary space below join the community section. and the containers of forum and discord are too small for the section which makes the UI a bit ugly.

Expected Behavior: There should be no extra space and the containers[links] should be a little big and also they should have a hover effect to it's secondary color

Steps to Reproduce:

  1. go to https://www.djangoproject.com/
  2. scroll down to "join the community" section

Suggested Solution:

  1. remove the extra space
  2. add a hover effect to links
  3. could also add a few more links if necessary

SrisailamKakurala avatar Dec 21 '24 14:12 SrisailamKakurala

@alex @jezdez @matthiask @justinabrahms can u please review the pr.

SrisailamKakurala avatar Dec 21 '24 15:12 SrisailamKakurala

Do not spam random people. It is incredible rude.

alex avatar Dec 21 '24 15:12 alex

sorry!! i'm new to open source and this is my first contribution. so i thought u guys were repo managers. pardon me alex. hope we'll get along.

SrisailamKakurala avatar Dec 21 '24 15:12 SrisailamKakurala

@SrisailamKakurala Are you saying that it's a problem that the sidebar content is adding vertical space to the layout more than the main content?

adamzap avatar Dec 21 '24 16:12 adamzap

@adamzap The side bar spacing is perfect but in the main layout i.e. below join the community section ... There's an additional vertical space which is occupied by a svg declaration.... Which is not being rendered there... So I changed its display to none ... Resulting in the elimination of space it took .... (See the code changes in #1843)

The svg is just a declaration for the theme icons that are used in the navbar. So we can just hide it to eliminate space. And also I added a hover effect to the links to join the community section.

SrisailamKakurala avatar Dec 21 '24 16:12 SrisailamKakurala