djangoproject.com icon indicating copy to clipboard operation
djangoproject.com copied to clipboard

Improve mobile markup on a docs page

Open circus2271 opened this issue 1 year ago • 7 comments

Mobile menu doesn't work 100% well on mobile devices. There is a bug when mobile menu doesn't close on a second button press

circus2271 avatar Mar 02 '24 02:03 circus2271

Some wild stuff happening

https://github.com/user-attachments/assets/f26a1913-63c9-44f5-9b0a-d1d7a10c8f83

circus2271 avatar Jun 23 '25 16:06 circus2271

So this pr just cancels css hover on mobile. So it won't affect the UX (menu shows and hides on tap, without additional logic)

Sorry for annoying with this, but I changed the text of this issue, so it's more clear what this pr does @sabderemane

circus2271 avatar Jun 23 '25 16:06 circus2271

(and also almost a year is gone)

circus2271 avatar Jun 23 '25 17:06 circus2271

@circus2271 Hi! Thank you for the report, it will be triaged by the Website Working Group 🎸

So this pr just cancels css hover on mobile. So it won't affect the UX (menu shows and hides on tap, without additional logic)

I'm not sure which PR you are talking about, do you have the link? Except if you are talking of the current issue.

sabderemane avatar Jun 23 '25 20:06 sabderemane

yeah, i thought it was linked to this issue...

here it is: https://github.com/django/djangoproject.com/pull/1489

circus2271 avatar Jun 24 '25 12:06 circus2271

@sabderemane

circus2271 avatar Jun 27 '25 14:06 circus2271

I'm quite busy these days, I will review it soon @circus2271 .

sabderemane avatar Jul 19 '25 13:07 sabderemane