djangoproject.com icon indicating copy to clipboard operation
djangoproject.com copied to clipboard

Menu button is not a button

Open xi opened this issue 3 years ago • 1 comments

The menu button for the mobile navigation is not accessible by keyboard because it is a <div> instead of a <button>

xi avatar Oct 11 '22 19:10 xi

How can your reporting of yours be verified in concrete? How would you change the button?

pauloxnet avatar Oct 12 '22 15:10 pauloxnet

@pauloxnet The menu button is indeed a div , yet it works perfectly , I faced no issue as the button not being clickable .I tested the website on multiple mobile browsers but didn't find any such problem.Attaching screenshot for refrence.

image

RyanWalker277 avatar Oct 17 '22 13:10 RyanWalker277

Let me be more specific about the steps to reproduce the issue:

Imagine you are a user with bad sight and bad hand-eye coordination. So you zoom in 400% and use the keyboard to navigate.

Expected experience: I can use the tab key to get to the menu button, and use the space key to open the menu.

What happens instead: The menu button is skipped. Instead the focus moves directly to the (invisible) menu.

xi avatar Oct 17 '22 14:10 xi

Fixed, see PR #1306

amit9838 avatar Jan 24 '23 06:01 amit9838

● mobile-menu js - djangoproject com - Visual Studio Code 24-01-2023 11_47_43

aviralshastri avatar Jan 24 '23 06:01 aviralshastri

Ok so, you want me to cancel my PR? right?

amit9838 avatar Jan 24 '23 06:01 amit9838

Please Assign me this issue.

Charan-Deep avatar Feb 21 '23 10:02 Charan-Deep

Screenshot (75) A "menu button" can refer to a specific type of button that is used to access a navigation menu on a website. This type of button is typically represented by an icon with three horizontal lines, often referred to as a "hamburger menu" icon.

So, in this context, the statement "menu button is button in website" would be correct. A menu button on a website is a type of button that is used to access a navigation menu, and it is an important element of website design and user experience.

YashGodwal avatar Apr 02 '23 07:04 YashGodwal

@pauloxnet Can I also proceed with this issue?

kaushal-malpure avatar Aug 25 '23 05:08 kaushal-malpure

@kaushal-malpure feel free to work on this, no need to be assigned to work on an issue :)

pauloxnet avatar Aug 25 '23 15:08 pauloxnet

Hey @pauloxnet , As per issue raised menu button div tag changed to button tag (PR#1402). Below is the attached screenshot for the same. Screenshot 2023-08-25 221958

kaushal-malpure avatar Aug 25 '23 17:08 kaushal-malpure

@kaushal-malpure please answer questions in your PR #1402

pauloxnet avatar Aug 28 '23 12:08 pauloxnet