djangoproject.com icon indicating copy to clipboard operation
djangoproject.com copied to clipboard

Add precommit

Open pauloxnet opened this issue 3 years ago • 2 comments

pauloxnet avatar Jul 22 '22 07:07 pauloxnet

@pauloxnet Thanks for this patch :+1: However, IMO we don't need most of this hooks. It's not really worth to optimize svg files, edits vendor libraries, or auto-generated migration files.

felixxm avatar Jul 22 '22 07:07 felixxm

I think that the end-file lines have been added to the SVG files or others file or trailing-spaces have been removed.

I use these hooks in all my repositories, but tell me what you think it is not good to add for this project that I remove them from the precommit file: https://github.com/pauloxnet/djangoproject.com/blob/feature/precommit/.pre-commit-config.yaml

pauloxnet avatar Jul 22 '22 08:07 pauloxnet

Close in favor of #1198

pauloxnet avatar Sep 03 '22 16:09 pauloxnet