django
django copied to clipboard
django
Fixed #3461 -- Made DatabaseWrapper.cursor() able to pass args/kwargs to the underlying database adapter.
created a cleaner pr from https://github.com/django/django/pull/8121
working on better docs and release notes
@carltongibson I am quite at a loss about how should I write docs for this patch as suggested in older pr. any help would be appreciated
@auvipy OK. I shall have a look. (In the meantime fancy fixing the isort error?)
I can fix the isort, and release note. but about the documentation I am quite not sure how to put them well and about wording/examples as I don't have proper real world use case right now to put some.
... I don't have proper real world use case ...
Hmmm. This isn't a good sign. If there's no use-case, what are we trying to fix?(If there's an answer to that, surely that's the use-case?)
well what I wanted to mean is I don't have to bypass django orm to use the lower level db connector/driver on a regular basis. but there should be users who need them
Sure, on the ticket there's this:
For example, to use dict cursors in psycopg2 you have to pass a different cursor factory via the cursor_factory keyword argument to cursor()
Can you use something like that to create the examples needed? (I guess the same would go into test cases...)
Yesterday. This isn't close enough to squeeze in I think. If it's going to go it'll need to be 2.2
@auvipy It's 10 years old. There's no rush. 😃
For me the biggest thing here is the docs: what's this for? (What's the actual use-case?) From there I'm sure there's not too much to do.
need to fix the merge conflict again + docs before april to get into 4.1 right? also want to know mergers input/thoughts of the suggestion made in https://github.com/django/django/pull/9674#discussion_r179945043
