django icon indicating copy to clipboard operation
django copied to clipboard

Published 20 hours ago • verified publisher icon django

Refs #34406 -- Added support for GDAL curved geometries.

Open smithdc1 opened this issue 11 months ago • 9 comments

Trac ticket number

ticket-34406

Branch description

Adds curved geometry support for GDAL geometries.

As part of this I tried to add the ForceTo* bindings (e.g. ForceToPolygon ). However, I was unable to achieve this. I think it's likely due to me not understanding the return type.

Returns: the converted geometry (ownership to caller).

While I've been unable to solve that problem I think it's likely reviewing the other work I've done here which adds recognition of these types and allows conversion between linear and curved geometries.

Checklist

  • [x] This PR targets the main branch.
  • [x] The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • [x] I have checked the "Has patch" ticket flag in the Trac system.
  • [x] I have added or updated relevant tests.
  • [x] I have added or updated relevant docs, including release notes if applicable.
  • [x] For UI changes, I have attached screenshots in both light and dark modes.

smithdc1 avatar Mar 23 '24 15:03 smithdc1

@claudep Hi! Would you have any time to take a look to this PR?

nessita avatar Apr 04 '24 13:04 nessita

@smithdc1 I'm going thru pending PRs that were on my "maybe 5.1" list, I wanted to double check that this is not yet ready for a re-review (given the ticket flags). Is that accurate?

nessita avatar May 20 '24 19:05 nessita

Hi @nessita it is quite close. However, I'd not worry about getting this in ahead of the feature freeze.

Let me update the versions and have a final look over. Maybe we can then get it in early in the next cycle?

smithdc1 avatar May 20 '24 19:05 smithdc1

Hi @nessita it is quite close. However, I'd not worry about getting this in ahead of the feature freeze.

Let me update the versions and have a final look over. Maybe we can then get it in early in the next cycle?

Yes, absolutely!

/remind me to check on this in one month and a half

nessita avatar May 31 '24 16:05 nessita

@nessita set a reminder for 6/30/2024

github-actions[bot] avatar May 31 '24 16:05 github-actions[bot]

:wave: @nessita, check on this and a half

github-actions[bot] avatar Jun 30 '24 09:06 github-actions[bot]

@nessita Do you think we could merge that work now?

claudep avatar Aug 16 '24 15:08 claudep

@nessita Do you think we could merge that work now?

Thank you Claude for the nudge, I'll re-review later this week! (currently dealing with release blockers and security reports).

nessita avatar Aug 19 '24 13:08 nessita

No rush, thanks for your amazing work! :heart_eyes:

claudep avatar Aug 19 '24 14:08 claudep