#34044 -- Add the admin app filter on index pages in addition to the nav sidebar

[Hisham-Pak]

Ticket: https://code.djangoproject.com/ticket/34044

[nessita]

Hello @Hisham-Pak, thank you for your work on this! A few initial comments:

• If this PR is based on PR #16107, the former author should be kept in the AUTHORS file and they should also be added to the commit message with Co-authored-by.
• From the same PR, there seems to be an outstanding comment that needs answering/addressing. Have you given it some consideration? Any conclusions?
• Could you please squash the commits into isolated logical units to ease the review? Specifically, we'd aim to have a commit history as usable as possible

Once these points are addressed, please unset the flag "patch needs improvement" in the ticket so we review again. Thanks again!

[nessita]

I forgot to add in my previous comment that these changes also need to include an entry in the docs/releases/5.1.txt file describing the new feature.

[Hisham-Pak]

@nessita, I added:

• The former author to AUTHORS file and made a commit message with Co-authored-by.
• Regarding this comment, I could not really visualize what @knyghty really meant (wouldn't sidebar really just duplicate models on index page?). Moreover, I think a new ticket should be opened to discuss about this feature.
• Squashed commits into cleaner history.
• Also added to release notes.

[nessita]

@nessita, I added:

Thank you @Hisham-Pak for the addings! Below some questions/comments.

* Regarding [this](https://github.com/django/django/pull/16107#issuecomment-1262098976) comment, I could not really visualize what @knyghty really meant (wouldn't sidebar really just duplicate models on index page?). Moreover, I think a new ticket should be opened to discuss about this feature.

That's a good question, I have asked Tom in our Discord server (thread) and it seems they meant that the filter should be shown also for model list at the app level (for example, under /admin/auth/).

I'll do a code review now and post my feedback.

[nessita]

This work may change pending resolution of https://forum.djangoproject.com/t/adding-the-admin-nav-sidebar-to-almost-every-page/26921

[knyghty]

My opinion on this at the moment is that based on this forum thread we should instead try to implement it via adding the nav sidebar across all pages. If that turns out to be more complex than I think it is, we should go back to this as an interim solution.