django icon indicating copy to clipboard operation
django copied to clipboard

Fixed #33871 -- Fix bug value cannot be detected after form validation fails

Open na86421 opened this issue 1 year ago • 3 comments

Fixed Ticket #33871

Changes

  • After form validation check fails, set form's data as initial data
  • Added set_initial_data function in BaseForm
  • Added unit test for set_intial_data

Description

It is better to initialize entered data(input) than not to be able to detect and save the changes after invalidation of form. But it seems to hurt ux a little.

na86421 avatar Aug 31 '22 12:08 na86421

@carltongibson @felixxm I fixed Ticket 33871. Could you please review this patch?

na86421 avatar Sep 01 '22 15:09 na86421

@na86421 You need to be patient, we will review it the coming days (weeks at worst).

felixxm avatar Sep 01 '22 17:09 felixxm

Thank you for reply.

I'm new to django contributions, but I haven't read the documentation thoroughly. Thanks to I have a good understanding of the culture and background :)

na86421 avatar Sep 07 '22 14:09 na86421

Closing in favor of #16229.

felixxm avatar Nov 02 '22 10:11 felixxm