django icon indicating copy to clipboard operation
django copied to clipboard

[PoC] Fixed #33735 -- Handle async streaming response

Open florianvazelle opened this issue 1 year ago • 4 comments

ticket-33735 Initial PoC to handle asynchronous responses in Django ASGI handler.

florianvazelle avatar May 23 '22 09:05 florianvazelle

Hello @florianvazelle! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

github-actions[bot] avatar May 23 '22 10:05 github-actions[bot]

Thanks @florianvazelle. I'll take a look this week.

carltongibson avatar May 23 '22 10:05 carltongibson

Hey, thanks for the review! I just pushed a new version taking into account your comments. I wrote a basic test, is there anything else to test, that I didn't take into account?

florianvazelle avatar Jun 06 '22 19:06 florianvazelle

Thanks @florianvazelle! I will take another look. 👍

carltongibson avatar Jun 07 '22 09:06 carltongibson

Closing as per ticket. @florianvazelle Thanks for this. If you fancy picking up on the alternate approach, please do say. 🎁

carltongibson avatar Nov 08 '22 07:11 carltongibson