django icon indicating copy to clipboard operation
django copied to clipboard

Refs #33604 -- allow the cache `key_prefix` to be a callable

Open alexei opened this issue 2 years ago • 14 comments

This update allows to set the key_prefix as a callable.

Discussions: https://code.djangoproject.com/ticket/33604 https://groups.google.com/g/django-developers/c/UbD1DkV1uPo

alexei avatar Mar 29 '22 09:03 alexei

Note I was able to run the tests in my account but they fail: https://github.com/alexei/django/actions/workflows/tests.yml

alexei avatar Mar 29 '22 09:03 alexei

Hello @alexei! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

github-actions[bot] avatar Mar 29 '22 09:03 github-actions[bot]

Note I was able to run the tests in my account but they fail: https://github.com/alexei/django/actions/workflows/tests.yml

That is no longer the case see https://github.com/alexei/django/actions/runs/2063824381

alexei avatar Mar 30 '22 09:03 alexei

@rixx Can you take a look?

felixxm avatar Mar 30 '22 09:03 felixxm

Looks good to me! Really cool to see this come to Django core.

Thanks for reviewing this. If this gets accepted, is it possible to make it available to all (2+) Django versions?

alexei avatar Mar 30 '22 13:03 alexei

Looks good to me! Really cool to see this come to Django core.

Thanks for reviewing this. If this gets accepted, is it possible to make it available to all (2+) Django versions?

No, we don't backport new features. Currently we develop Django 4.1.

felixxm avatar Mar 30 '22 14:03 felixxm

Thank you! The extended documentation is really cool and helpful.

rixx avatar Mar 30 '22 19:03 rixx

@felixxm @rixx what are the next steps? Is there anything else I need to do here?

alexei avatar Mar 31 '22 09:03 alexei

@felixxm @rixx what are the next steps? Is there anything else I need to do here?

You need to be patient, we will review it the coming days (weeks at worst). At first glance release notes, and versionchanged/versionadded annotations are missing, see docs.

felixxm avatar Mar 31 '22 09:03 felixxm

@alexei Do you have time to keep working on this? (and add missing docs changes before our review).

felixxm avatar Apr 13 '22 09:04 felixxm

Yes, I have both assigned tickets in my todo list for today.

alexei avatar Apr 13 '22 09:04 alexei

Btw, what should I use for A.B?

alexei avatar Apr 13 '22 09:04 alexei

Btw, what should I use for A.B?

4.1

felixxm avatar Apr 13 '22 09:04 felixxm

@felixxm I updated the release notes. Please LMK if I got it right.

alexei avatar Apr 13 '22 10:04 alexei