django
django copied to clipboard
Refs #33604 -- allow the cache `key_prefix` to be a callable
This update allows to set the key_prefix as a callable.
Discussions: https://code.djangoproject.com/ticket/33604 https://groups.google.com/g/django-developers/c/UbD1DkV1uPo
Note I was able to run the tests in my account but they fail: https://github.com/alexei/django/actions/workflows/tests.yml
Hello @alexei! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
Note I was able to run the tests in my account but they fail: https://github.com/alexei/django/actions/workflows/tests.yml
That is no longer the case see https://github.com/alexei/django/actions/runs/2063824381
@rixx Can you take a look?
Looks good to me! Really cool to see this come to Django core.
Thanks for reviewing this. If this gets accepted, is it possible to make it available to all (2+) Django versions?
Looks good to me! Really cool to see this come to Django core.
Thanks for reviewing this. If this gets accepted, is it possible to make it available to all (2+) Django versions?
No, we don't backport new features. Currently we develop Django 4.1.
Thank you! The extended documentation is really cool and helpful.
@felixxm @rixx what are the next steps? Is there anything else I need to do here?
@felixxm @rixx what are the next steps? Is there anything else I need to do here?
You need to be patient, we will review it the coming days (weeks at worst). At first glance release notes, and versionchanged
/versionadded
annotations are missing, see docs.
@alexei Do you have time to keep working on this? (and add missing docs changes before our review).
Yes, I have both assigned tickets in my todo list for today.
Btw, what should I use for A.B?
Btw, what should I use for A.B?
4.1
@felixxm I updated the release notes. Please LMK if I got it right.